Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.8.0rc2 #134

Merged
merged 5 commits into from
Mar 1, 2024
Merged

v1.8.0rc2 #134

merged 5 commits into from
Mar 1, 2024

Conversation

arthurcht
Copy link
Contributor

for pre-release v1.8.0rc2,

  • Remove dbt-adapters requirement in setup.py, and specify commit SHA of dbt-core and dbt-adapters in dev_requirements.txt, to fix make dev
  • Fix failing test tests/functional/adapter/test_query_comment.py::TestMacroArgsQueryComments::test_matches_comment to use correct dbt_version, see dbt-core

@arthurcht
Copy link
Contributor Author

merging because PR already reviewed in #133

@arthurcht arthurcht merged commit 465e712 into main Mar 1, 2024
19 of 26 checks passed
@arthurcht arthurcht deleted the hotfix/v1.8.0rc2_dataroots branch March 1, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant